HBASE-22567 - HBCK2 addMissingRegionsToMeta#18
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
retest build |
|
Refer to this link for build results (access rights to CI server needed): |
wchevreuil
force-pushed
the
HBASE-22567-rebased
branch
from
d1ec30c to
88f96b3
Compare
|
Refer to this link for build results (access rights to CI server needed): |
Addressing following PR suggestions: 1) should we be throwing an exception to fail the tool run here? 2) could we add an option to fail the command if the disable fails? for folks who don't want to risk the overlap?
|
Refer to this link for build results (access rights to CI server needed): |
| admin.enableTable(tableName); | ||
| } catch (IOException e) { | ||
| LOG.debug("Failed enabling table {}. It might be that namespace table " | ||
| + "region is also missing.\n" |
There was a problem hiding this comment.
Shouldn't these debug be under System.out.println? As this is important for the user that hbck2 did not leave the tables in the same state they were.
There was a problem hiding this comment.
This is a bit of a dilema. On the cases I had been using this fix option, many often, namespace table was among the affected ones, which caused both disabling/enabling to fail, even though we didn't really care about it at this point. I was initially printing all errors, but that mislead operators to think the fix didn't work, when it actually did.
There was a problem hiding this comment.
I can understand your concern but these warnings should not be in debug, at least in WARN.
There was a problem hiding this comment.
WARN would be printed on console and cause same confusion as System.out.println. Moreover, if table enabling is failing for other reasons than namespace table not online, further problems would be manifesting on the cluster and those would need to be addressed on its own before operator can expect to run hbck2 properly.
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
…n -skip flag if namespace region is among the missing ones.
…2.meta' package to project's top level package.
…configuration) by CommonFSUtils.getRootDirFileSystem(configuration)
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Lets try and get this in @wchevreuil I want to make a release of the hbase-operator-tools. Need this. Once in, I'll some text to the fixit section in hbck2 README talking up this facility. Thanks boss. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Sure, let me get this committed, then. |
|
I have this merged and conflicts resolved on my local master branch, but faced the problem raised on HBASE-22984. We need to get HBASE-22984 committed first, otherwise this one will fail hbck2 build. |
|
Thanks for reviewing HBASE-22984 PR @busbey! Had it merged, let me now work on the commit for this one. |
|
Committed to master. |
5 participants
Rebased to current master and resolved conflicts.